Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

fix: avoid views when querying BigLake tables from SQL cells#2545

Closed
tswast wants to merge 2 commits intomainfrom
tswast-sql-cell-biglake
Closed

fix: avoid views when querying BigLake tables from SQL cells#2545
tswast wants to merge 2 commits intomainfrom
tswast-sql-cell-biglake

Conversation

@tswast
Copy link
Copy Markdown
Contributor

@tswast tswast commented Mar 31, 2026

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Workaround for internal issue b/493608478 🦕

@tswast tswast requested review from a team as code owners March 31, 2026 19:18
@tswast tswast requested a review from TrevorBergeron March 31, 2026 19:18
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Mar 31, 2026
@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Mar 31, 2026
@tswast
Copy link
Copy Markdown
Contributor Author

tswast commented Mar 31, 2026 •
edited
Loading

test_read_gbq_w_ambigous_name failure looks like a real one. I'll revert the change to the ibis compiler. I don't think that part is necessary for the workaround. Just aesthetic for how we escape query parts.

Edit: done in latest commit.

@tswast
Copy link
Copy Markdown
Contributor Author

tswast commented Apr 1, 2026

Closing. Let's move this over to https://github.com/googleapis/google-cloud-python once googleapis/google-cloud-python#16493 merges.

@tswast tswast closed this Apr 1, 2026
@tswast tswast mentioned this pull request Apr 6, 2026
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron TrevorBergeron is a code owner automatically assigned from googleapis/bigquery-dataframe-team

Assignees

@GarrettWu GarrettWu

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast @GarrettWu